Update test values that were broken by Terra transpilation changes #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In this PR I simply copied and pasted the values to make the tests pass. The values themselves still need to be manually checked for correctness (otherwise the test is pointless). @nonhermitian since you wrote this test and are more familiar with how mapomatic works I was hoping you could do that when you review this. |
|
This has been handled as part of #57 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52 .
The test was broken by Qiskit/qiskit#8552.
Note that this change itself is broken by Qiskit/qiskit#9026, so the test will need to be updated again for the version of Terra that includes that change. Perhaps this indicates that the test should be modified. Apparently, the output of the call
can change with new versions of Terra. We should also consider pinning the version of Terra used by mapomatic.